Skip to content

Conversation

@jialinli98
Copy link
Collaborator

@jialinli98 jialinli98 commented Jan 28, 2026

Description

Problem*

  1. Fix deprecated nargo prove/verify. Replaced with nargo execute + bb prove/verify
  2. Combined VK generation and proof generation using --write_vk flag (to avoid OOM), fixed verify commands to use correct paths
  3. Use resolve_foreign_call in oracle handler
  4. Removed split for u128 since we handle it as one element now
  5. Set up Alchemy url for RPC calls
  6. customized U256 conversion functions to avoid Error: Input to Brillig function is in a separate subgraph to output #19 Need more investigation
  7. Added --skip-brillig-constraints-check flag to avoid Error: Brillig function call isn't properly covered by a manual constraint #18 Need more investigation
  8. commented out recursive witness generation in CI due to memory constraints
  9. commented out e2e tests because of error. Needs more investigation
    Resolves

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jialinli98 jialinli98 changed the title feat: ci fix: fix deprecated proving system commands Jan 28, 2026
@jialinli98 jialinli98 requested a review from TomAFrench January 28, 2026 08:57
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a few small questions about areas we can make this simpler.

Comment on lines 6 to 9
[profile.ci]
src = "src"
out = "out"
libs = ["lib"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a separate CI profile which is the same as the default?

@TomAFrench TomAFrench merged commit 8e1a90b into main Jan 30, 2026
14 checks passed
@TomAFrench TomAFrench deleted the jl/misc branch January 30, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants