Fix nextjs ci tests complete #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix JSON import syntax in test file for ES modules compatibility - Simplify API endpoint to avoid WASM loading issues in Next.js server environment - Remove problematic server-side test that was causing failures - Clean up Next.js configuration - All browser tests now pass successfully
- Add new Pages Router API endpoint at /api/verify for server-side verification - Update Next.js configuration with proper WASM file tracing for Pages Router - Add server-side test that successfully verifies proofs on the server - Fix proof serialization/deserialization between client and server - All tests now pass: 3 browser tests + 3 server-side tests = 6/6 ✅ Key improvements: - Uses Pages Router (/pages/api/) instead of App Router for better WASM support - Proper outputFileTracingIncludes configuration for @aztec/bb.js WASM files - Robust proof format handling for serialized Uint8Array objects - Demonstrates both client-side and server-side Noir proof verification
critesjosh
added a commit
that referenced
this pull request
Jul 3, 2025
* Add initial Next.js project structure for Noir UH Starter - Created essential files including package.json, TypeScript configuration, and Playwright configuration. - Added global styles and layout components for the application. - Implemented a proof generation component with state management and proof verification logic. - Included a README for setup and usage instructions. - Established a .gitignore to exclude unnecessary files and directories. * test nextjs * rename folder * fix dir name * fix port * add api * update path, test * Fix nextjs ci tests complete (#75) * Fix Next.js Playwright tests - Fix JSON import syntax in test file for ES modules compatibility - Simplify API endpoint to avoid WASM loading issues in Next.js server environment - Remove problematic server-side test that was causing failures - Clean up Next.js configuration - All browser tests now pass successfully * Implement working server-side proof verification using Pages Router - Add new Pages Router API endpoint at /api/verify for server-side verification - Update Next.js configuration with proper WASM file tracing for Pages Router - Add server-side test that successfully verifies proofs on the server - Fix proof serialization/deserialization between client and server - All tests now pass: 3 browser tests + 3 server-side tests = 6/6 ✅ Key improvements: - Uses Pages Router (/pages/api/) instead of App Router for better WASM support - Proper outputFileTracingIncludes configuration for @aztec/bb.js WASM files - Robust proof format handling for serialized Uint8Array objects - Demonstrates both client-side and server-side Noir proof verification --------- Co-authored-by: openhands <[email protected]> * Add issue creation step for nightly workflow failures in Playwright CI * working * chore: cleanup next config * chore: add config comments * chore: add crsPath option * update nextjs version --------- Co-authored-by: openhands <[email protected]> Co-authored-by: saleel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
Additional Context
PR Checklist*
cargo fmton default settings.