-
Notifications
You must be signed in to change notification settings - Fork 36
Update the nightly tests to run the latest published version of npm packages #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cypriansakwa
wants to merge
21
commits into
noir-lang:master
Choose a base branch
from
cypriansakwa:update-nightly-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
51b1966
Update the nightly tests to run the latest published version of npm p…
cypriansakwa b47fb11
Combine npm-check-updates install and upgrade steps into a single step
cypriansakwa e7f9339
update bignum_example.yml
cypriansakwa 92bba62
Resolve conflict
cypriansakwa f886c2b
update nightly CI to auto-upgrade Noir/Barretenberg dependencies
cypriansakwa 12c6d1c
Update solidity-example.yml
cypriansakwa 6b2a230
Update recursion.yml
cypriansakwa 892722b
Update web-starter-playwright.yml
cypriansakwa 59648d4
ci: auto-detect and install correct Barretenberg CLI version based on…
cypriansakwa 4b8338d
ci: auto-detect and install correct Barretenberg CLI and matching JS …
cypriansakwa 572a47a
Update recursion.yml
cypriansakwa cf53c7a
Update solidity-example.yml
cypriansakwa 0b1669b
Update web-starter-playwright.yml
cypriansakwa b8f265d
Update recursion.yml
cypriansakwa e054358
Update solidity-example.yml
cypriansakwa 13f8c71
Update web-starter-playwright.yml
cypriansakwa 8c90dcb
Resolve bbup install conflicts: use master branch + PATH export
cypriansakwa 591bdf3
Merge branch 'master' into update-nightly-tests
cypriansakwa c241688
Update solidity-example.yml
cypriansakwa af206a3
Merge branch 'master' into update-nightly-tests
cypriansakwa 16001c1
Merge branch 'master' into update-nightly-tests
cypriansakwa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| # a github workflow that runs curl -L https://foundry.paradigm.xyz | bash then nargo codegen-verifier then nargo prove p | ||
|
|
||
| name: Run solidity-example Tests on PR | ||
| on: | ||
| pull_request: | ||
|
|
@@ -25,20 +23,37 @@ jobs: | |
| uses: noir-lang/[email protected] | ||
| with: | ||
| toolchain: stable | ||
|
|
||
| - name: Run Noir unit tests | ||
| working-directory: solidity-example/circuits | ||
| run: | | ||
| nargo test | ||
|
|
||
| - name: Install bb | ||
| - name: Determine and install compatible Barretenberg CLI | ||
| id: install-bb | ||
| shell: bash | ||
| run: | | ||
| curl -L https://raw.githubusercontent.com/AztecProtocol/aztec-packages/refs/heads/master/barretenberg/bbup/install | bash | ||
| echo "PATH=$PATH:/home/runner/.bb" >> $GITHUB_ENV | ||
| sudo apt-get update && sudo apt-get install -y jq | ||
|
|
||
| NOIR_VERSION=$(nargo --version | awk '{print $2}') | ||
| echo "Detected Noir version: $NOIR_VERSION" | ||
|
|
||
| curl -sL https://raw.githubusercontent.com/AztecProtocol/aztec-packages/master/barretenberg/bbup/bb-versions.json -o bb-versions.json | ||
| BB_VERSION=$(jq -r --arg v "$NOIR_VERSION" '.[$v]' bb-versions.json) | ||
|
|
||
| if [ "$BB_VERSION" = "null" ]; then | ||
| echo "No compatible bb version for Noir $NOIR_VERSION" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "Using Barretenberg version: $BB_VERSION" | ||
| curl -L "https://github.com/AztecProtocol/barretenberg/releases/download/v${BB_VERSION}/bb-linux" -o /usr/local/bin/bb | ||
cypriansakwa marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| chmod +x /usr/local/bin/bb | ||
|
|
||
| - name: Run bbup | ||
| echo "bb_version=$BB_VERSION" >> $GITHUB_OUTPUT | ||
| echo "noir_version=$NOIR_VERSION" >> $GITHUB_OUTPUT | ||
|
|
||
| bb --version | ||
|
|
||
| - name: Run Noir unit tests | ||
| working-directory: solidity-example/circuits | ||
| run: | | ||
| bbup | ||
| nargo test | ||
|
|
||
| - name: Install Foundry | ||
| uses: foundry-rs/foundry-toolchain@v1 | ||
|
|
@@ -47,7 +62,13 @@ jobs: | |
| run: | | ||
| ./build.sh | ||
| working-directory: solidity-example/circuits | ||
|
|
||
|
|
||
| - name: Install matching @aztec/bb.js version | ||
| working-directory: solidity-example/js | ||
| run: | | ||
| BB_VERSION=${{ steps.install-bb.outputs.bb_version }} | ||
| yarn add @aztec/bb.js@$BB_VERSION --exact | ||
|
|
||
| - name: Install npm-check-updates and upgrade dependencies | ||
| if: github.event_name == 'schedule' | ||
| working-directory: solidity-example/js | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.