chore!: restrict MemOp to only take witnesses
#11209
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: fc7ed7d | Previous: e68a755 | Ratio |
|---|---|---|---|
test_report_zkpassport_noir-ecdsa_ |
3 s |
2 s |
1.50 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
TomAFrench
commented
Jan 14, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
ACVM Benchmarks
Details
| Benchmark suite | Current: fc7ed7d | Previous: e68a755 | Ratio |
|---|---|---|---|
purely_sequential_opcodes |
253139 ns/iter (± 403) |
268301 ns/iter (± 824) |
0.94 |
perfectly_parallel_opcodes |
223966 ns/iter (± 5121) |
238059 ns/iter (± 1518) |
0.94 |
perfectly_parallel_batch_inversion_opcodes |
2794565 ns/iter (± 3602) |
2805529 ns/iter (± 725) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Test Suite Duration
Details
| Benchmark suite | Current: fc7ed7d | Previous: e68a755 | Ratio |
|---|---|---|---|
test_report_AztecProtocol_aztec-packages_noir-projects_aztec-nr |
155 s |
154 s |
1.01 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-contracts |
176 s |
170 s |
1.04 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob |
172 s |
181 s |
0.95 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_private-kernel-lib |
381 s |
392 s |
0.97 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_types |
154 s |
153 s |
1.01 |
test_report_noir-lang_noir-bignum_ |
169 s |
167 s |
1.01 |
test_report_noir-lang_noir_bigcurve_ |
282 s |
287 s |
0.98 |
test_report_noir-lang_sha256_ |
20 s |
19 s |
1.05 |
test_report_noir-lang_sha512_ |
14 s |
15 s |
0.93 |
test_report_zkpassport_noir-ecdsa_ |
3 s |
2 s |
1.50 |
test_report_zkpassport_noir_rsa_ |
1 s |
2 s |
0.50 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Compilation Memory
Details
| Benchmark suite | Current: fc7ed7d | Previous: e68a755 | Ratio |
|---|---|---|---|
private-kernel-inner |
284.45 MB |
285.98 MB |
0.99 |
private-kernel-reset |
498.3 MB |
510.4 MB |
0.98 |
private-kernel-tail |
257.55 MB |
259 MB |
0.99 |
rollup-block-root-first-empty-tx |
338.69 MB |
338.76 MB |
1.00 |
rollup-block-root-single-tx |
337.19 MB |
337.2 MB |
1.00 |
rollup-block-root |
339.38 MB |
339.74 MB |
1.00 |
rollup-checkpoint-merge |
339.88 MB |
340.07 MB |
1.00 |
rollup-checkpoint-root-single-block |
11290 MB |
11290 MB |
1 |
rollup-checkpoint-root |
11290 MB |
11290 MB |
1 |
rollup-root |
415.83 MB |
421.62 MB |
0.99 |
rollup-tx-base-private |
1050 MB |
1070 MB |
0.98 |
rollup-tx-base-public |
3030 MB |
3030 MB |
1 |
rollup-tx-merge |
336.15 MB |
336.33 MB |
1.00 |
semaphore_depth_10 |
93.74 MB |
98.09 MB |
0.96 |
sha512_100_bytes |
186.11 MB |
186.04 MB |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Execution Memory
Details
| Benchmark suite | Current: fc7ed7d | Previous: e68a755 | Ratio |
|---|---|---|---|
private-kernel-inner |
266.03 MB |
270.33 MB |
0.98 |
private-kernel-reset |
288.71 MB |
306.05 MB |
0.94 |
private-kernel-tail |
255.44 MB |
257.55 MB |
0.99 |
rollup-block-root |
337.54 MB |
337.74 MB |
1.00 |
rollup-checkpoint-merge |
336.39 MB |
336.57 MB |
1.00 |
rollup-checkpoint-root-single-block |
1750 MB |
1750 MB |
1 |
rollup-checkpoint-root |
1750 MB |
1750 MB |
1 |
rollup-root |
352.57 MB |
360.97 MB |
0.98 |
rollup-tx-base-private |
454 MB |
525.46 MB |
0.86 |
rollup-tx-base-public |
465.09 MB |
466.59 MB |
1.00 |
rollup-tx-merge |
335.7 MB |
335.81 MB |
1.00 |
semaphore_depth_10 |
73.02 MB |
74.22 MB |
0.98 |
sha512_100_bytes |
71.75 MB |
72.47 MB |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Opcode count
Details
| Benchmark suite | Current: fc7ed7d | Previous: e68a755 | Ratio |
|---|---|---|---|
private-kernel-inner |
20083 opcodes |
20083 opcodes |
1 |
private-kernel-reset |
80482 opcodes |
80482 opcodes |
1 |
private-kernel-tail |
8549 opcodes |
8549 opcodes |
1 |
rollup-block-root-first-empty-tx |
1082 opcodes |
1082 opcodes |
1 |
rollup-block-root-single-tx |
967 opcodes |
967 opcodes |
1 |
rollup-block-root |
2169 opcodes |
2169 opcodes |
1 |
rollup-checkpoint-merge |
1902 opcodes |
1902 opcodes |
1 |
rollup-checkpoint-root-single-block |
1819274 opcodes |
1819274 opcodes |
1 |
rollup-checkpoint-root |
1820467 opcodes |
1820467 opcodes |
1 |
rollup-root |
49245 opcodes |
49245 opcodes |
1 |
rollup-tx-base-private |
302291 opcodes |
302291 opcodes |
1 |
rollup-tx-base-public |
257974 opcodes |
257974 opcodes |
1 |
rollup-tx-merge |
1302 opcodes |
1302 opcodes |
1 |
semaphore-depth-10 |
5699 opcodes |
5699 opcodes |
1 |
sha512-100-bytes |
13173 opcodes |
13173 opcodes |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Artifact Size
Details
| Benchmark suite | Current: fc7ed7d | Previous: e68a755 | Ratio |
|---|---|---|---|
private-kernel-inner |
933.7 KB |
938 KB |
1.00 |
private-kernel-reset |
2045.2 KB |
2063.1 KB |
0.99 |
private-kernel-tail |
467.8 KB |
468.1 KB |
1.00 |
rollup-block-root-first-empty-tx |
219.5 KB |
219.6 KB |
1.00 |
rollup-block-root-single-tx |
223 KB |
223.1 KB |
1.00 |
rollup-block-root |
291.3 KB |
291.4 KB |
1.00 |
rollup-checkpoint-merge |
384.2 KB |
384.9 KB |
1.00 |
rollup-checkpoint-root-single-block |
48303 KB |
48352.7 KB |
1.00 |
rollup-checkpoint-root |
48370.7 KB |
48422.1 KB |
1.00 |
rollup-root |
1207.7 KB |
1208 KB |
1.00 |
rollup-tx-base-private |
5364.9 KB |
5443.8 KB |
0.99 |
rollup-tx-base-public |
4734.4 KB |
4759.1 KB |
0.99 |
rollup-tx-merge |
167.9 KB |
167.9 KB |
1 |
semaphore-depth-10 |
551 KB |
551.2 KB |
1.00 |
sha512-100-bytes |
437.4 KB |
473.5 KB |
0.92 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Execution Time
Details
| Benchmark suite | Current: fc7ed7d | Previous: e68a755 | Ratio |
|---|---|---|---|
private-kernel-inner |
0.04 s |
0.045 s |
0.89 |
private-kernel-reset |
0.217 s |
0.216 s |
1.00 |
private-kernel-tail |
0.008 s |
0.008 s |
1 |
rollup-block-root-first-empty-tx |
0.003 s |
0.003 s |
1 |
rollup-block-root-single-tx |
0.003 s |
0.004 s |
0.75 |
rollup-block-root |
0.004 s |
0.004 s |
1 |
rollup-checkpoint-merge |
0.003 s |
0.003 s |
1 |
rollup-checkpoint-root-single-block |
27.1 s |
27.7 s |
0.98 |
rollup-checkpoint-root |
27.8 s |
27.7 s |
1.00 |
rollup-root |
0.049 s |
0.048 s |
1.02 |
rollup-tx-base-private |
0.331 s |
0.34 s |
0.97 |
rollup-tx-base-public |
0.261 s |
0.257 s |
1.02 |
rollup-tx-merge |
0.002 s |
0.002 s |
1 |
semaphore-depth-10 |
0.009 s |
0.009 s |
1 |
sha512-100-bytes |
0.085 s |
0.049 s |
1.73 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: fc7ed7d | Previous: e68a755 | Ratio |
|---|---|---|---|
sha512-100-bytes |
0.085 s |
0.049 s |
1.73 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Contributor
There was a problem hiding this comment.
Brillig Execution Time
Details
| Benchmark suite | Current: fc7ed7d | Previous: e68a755 | Ratio |
|---|---|---|---|
private-kernel-inner |
0.03 s |
0.034 s |
0.88 |
private-kernel-reset |
0.102 s |
0.101 s |
1.01 |
private-kernel-tail |
0.006 s |
0.005 s |
1.20 |
rollup-block-root-first-empty-tx |
0.004 s |
0.004 s |
1 |
rollup-block-root-single-tx |
0.003 s |
0.003 s |
1 |
rollup-block-root |
0.003 s |
0.003 s |
1 |
rollup-checkpoint-merge |
0.001 s |
0.001 s |
1 |
rollup-root |
0.009 s |
0.009 s |
1 |
rollup-tx-base-private |
0.039 s |
0.038 s |
1.03 |
rollup-tx-base-public |
0.045 s |
0.049 s |
0.92 |
rollup-tx-merge |
0.002 s |
0.002 s |
1 |
semaphore-depth-10 |
0.028 s |
0.026 s |
1.08 |
sha512-100-bytes |
0.017 s |
0.017 s |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Brillig Compilation Time
Details
| Benchmark suite | Current: fc7ed7d | Previous: e68a755 | Ratio |
|---|---|---|---|
private-kernel-inner |
1.25 s |
1.254 s |
1.00 |
private-kernel-reset |
1.244 s |
1.232 s |
1.01 |
private-kernel-tail |
1.046 s |
1.034 s |
1.01 |
rollup-block-root-first-empty-tx |
1.456 s |
1.63 s |
0.89 |
rollup-block-root-single-tx |
1.44 s |
1.36 s |
1.06 |
rollup-block-root |
1.52 s |
1.47 s |
1.03 |
rollup-checkpoint-merge |
1.452 s |
1.462 s |
0.99 |
rollup-checkpoint-root-single-block |
1.87 s |
1.84 s |
1.02 |
rollup-checkpoint-root |
2.02 s |
1.94 s |
1.04 |
rollup-root |
1.56 s |
1.514 s |
1.03 |
rollup-tx-base-private |
1.654 s |
1.67 s |
0.99 |
rollup-tx-base-public |
1.632 s |
1.63 s |
1.00 |
rollup-tx-merge |
1.49 s |
1.366 s |
1.09 |
semaphore-depth-10 |
0.247 s |
0.243 s |
1.02 |
sha512-100-bytes |
0.208 s |
0.204 s |
1.02 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Brillig Artifact Size
Details
| Benchmark suite | Current: fc7ed7d | Previous: e68a755 | Ratio |
|---|---|---|---|
private-kernel-inner |
671.1 KB |
671.1 KB |
1 |
private-kernel-reset |
681.2 KB |
681.2 KB |
1 |
private-kernel-tail |
291.7 KB |
291.7 KB |
1 |
rollup-block-root-first-empty-tx |
245 KB |
245 KB |
1 |
rollup-block-root-single-tx |
244.3 KB |
244.3 KB |
1 |
rollup-block-root |
300.7 KB |
300.7 KB |
1 |
rollup-checkpoint-merge |
275 KB |
275 KB |
1 |
rollup-checkpoint-root-single-block |
528.7 KB |
528.7 KB |
1 |
rollup-checkpoint-root |
567.9 KB |
567.9 KB |
1 |
rollup-root |
463.2 KB |
463.2 KB |
1 |
rollup-tx-base-private |
639.5 KB |
639.5 KB |
1 |
rollup-tx-base-public |
756.7 KB |
756.7 KB |
1 |
rollup-tx-merge |
190.5 KB |
190.5 KB |
1 |
semaphore-depth-10 |
2068.7 KB |
2068.7 KB |
1 |
sha512-100-bytes |
161.5 KB |
161.5 KB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Compilation Time
Details
| Benchmark suite | Current: fc7ed7d | Previous: e68a755 | Ratio |
|---|---|---|---|
private-kernel-inner |
2.418 s |
2.512 s |
0.96 |
private-kernel-reset |
8.256 s |
8.178 s |
1.01 |
private-kernel-tail |
2.476 s |
2.244 s |
1.10 |
rollup-block-root-first-empty-tx |
1.506 s |
1.594 s |
0.94 |
rollup-block-root-single-tx |
1.44 s |
1.37 s |
1.05 |
rollup-block-root |
1.58 s |
1.56 s |
1.01 |
rollup-checkpoint-merge |
1.58 s |
1.564 s |
1.01 |
rollup-checkpoint-root-single-block |
396 s |
397 s |
1.00 |
rollup-checkpoint-root |
451 s |
410 s |
1.10 |
rollup-root |
3.106 s |
3.088 s |
1.01 |
rollup-tx-base-private |
22.56 s |
23.9 s |
0.94 |
rollup-tx-base-public |
86.84 s |
83.44 s |
1.04 |
rollup-tx-merge |
1.538 s |
1.402 s |
1.10 |
semaphore-depth-10 |
0.906 s |
0.913 s |
0.99 |
sha512-100-bytes |
1.635 s |
1.693 s |
0.97 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
Resolves
Summary
Additional Context
User Documentation
Check one:
PR Checklist
cargo fmton default settings.