-
Notifications
You must be signed in to change notification settings - Fork 370
feat: potentially set brillig functions to pure if not entry points #11278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Changes to number of Brillig opcodes executed
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: ffe2817 | Previous: e48a0d8 | Ratio |
|---|---|---|---|
test_report_zkpassport_noir-ecdsa_ |
3 s |
1 s |
3 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 09f6b06 | Previous: 13ce5c8 | Ratio |
|---|---|---|---|
rollup-block-root |
0.005 s |
0.004 s |
1.25 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
vezenovm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asterite if I remember correctly this change started causes failures on aztec-packages once Noir got synced. Do you remember?
@jialinli98 it may be a good idea to mirror these changes onto aztec-packages to see if we get any test failures before merging.
|
I've opened a PR to run the full CI on this change in AztecProtocol/aztec-packages#19802 |
|
Interesting that there's regressions in |
Description
Problem
same changes as #9659
Noir and avm-transpiler build were successful. Noir projects can also be compiled with no error.
Summary
Additional Context
User Documentation
Check one:
PR Checklist
cargo fmton default settings.