Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(optimization): Don't defunctionalize acir functions #7215

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Jan 28, 2025

Description

Problem*

Summary*

This shouldn't be necessary know that we separate constrained-ness during monomorphization. Not sure if it'd result in any optimization changes yet though.

This seems to be causing a panic currently passing a function to brillig. We could maybe just change the translator to translate function inputs as fields.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Memory'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 8a95db8 Previous: dc06d8e Ratio
rollup-base-public 1880 MB 750.19 MB 2.51
rollup-base-private 1060 MB 610.93 MB 1.74
private-kernel-reset 460 MB 246.6 MB 1.87
private-kernel-inner 270.47 MB 210.12 MB 1.29

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant