Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: convert TraitMethodNotInScope to error #7427

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Feb 18, 2025

Description

Problem*

Part of #6932

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench
Copy link
Member Author

@kashbrti Looks like we're triggering this error in some of the noir libraries. It should just need the trait to be imported (there should be warnings being emitted for these), can you take a look at fixing these?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 929cdbe Previous: 757e3c4 Ratio
AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob 66 s 54 s 1.22

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@kashbrti
Copy link
Contributor

@TomAFrench the issue with noir-rsa is actually stemming from bignum. I made a change so that the RuntimeBignumTrait would be public. also made a change in noir-edwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants