-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(experiment): Compare bincode against other serialisation formats #7513
Draft
aakoshh
wants to merge
25
commits into
master
Choose a base branch
from
7511-compare-program-ser
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20
.
Benchmark suite | Current: 67e98a9 | Previous: 6f78848 | Ratio |
---|---|---|---|
global_var_regression_entry_points |
2.03 s |
0.541 s |
3.75 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
bf8a365
to
d9df721
Compare
c14a35f
to
52da1a6
Compare
52da1a6
to
e21fccc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Related to #7511
Summary*
Comparing the impact on bytecode size of switching to a different serialisation format.
Additional Context
I'm interested in figuring out whether we can use one of the schema-less formats without paying too high a price for a backwards compatible format in terms of bloated bytecode size.
Compiling contracts
Run these commands to compile noir protocol circuits and contracts in aztec-packages after rebuilding
nargo
:Baseline
Recorded the bytecode size with
bincode
before switching to other implementations:./scripts/bytecode-sizes/print-bytecode-size.sh ../aztec-packages > ./scripts/bytecode-sizes/bincode.jsonl
Comparing bytecode
Run these commands to record a new measurement (e.g.
flexbuffers
here) and compare againstbincode
.Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.