Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: vector optimizations #39

Merged
merged 17 commits into from
Feb 25, 2025
Merged

feat!: vector optimizations #39

merged 17 commits into from
Feb 25, 2025

Conversation

zac-williamson
Copy link
Collaborator

@zac-williamson zac-williamson commented Feb 18, 2025

Description

Big speedup for variable-length encoding and decoding
Solves #26

Problem*

variable-length encoding/decoding is needed to process jwts

Summary*

interface refactor to make encoding/decoding pure functions
more delicate handling of variable-length edge cases by using lookup tables as state machines instead of using branching logic

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is committing a lot of files which should be added to the .gitignore

@saleel saleel force-pushed the zw/vector-optimizations branch from cb3f3e6 to dc27b43 Compare February 20, 2025 13:10
@saleel saleel force-pushed the zw/vector-optimizations branch from dc27b43 to 81e4283 Compare February 20, 2025 13:10
@saleel
Copy link
Member

saleel commented Feb 20, 2025

This is committing a lot of files which should be added to the .gitignore

Yea, just removed them

@TomAFrench This PR is using BoundedVec::from_parts_unchecked which came only in 1.0.0.beta1 iirc. Is it required to have all releases of this lib work from Noir 0.36.0 onwards?

Is it ok to change this value?

@kashbrti
Copy link
Contributor

@TomAFrench I think this just needs your approval to be merged in now. also added the benchmarking workflow, it's currently failing because it can't find the artefact on the main branch (because it's just being added I think).

@TomAFrench TomAFrench merged commit 453401f into main Feb 25, 2025
6 of 7 checks passed
@github-actions github-actions bot mentioned this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants