chore: remove unnecessary slice usage (#39)

noir-lang · Feb 25, 2025 · 718fc56 · 718fc56
1 parent 98080a9
commit 718fc56
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/src/bigcurve_test.nr b/src/bigcurve_test.nr
@@ -60,9 +60,8 @@ unconstrained fn evaluate_mul(P: BN254J, scalar: ScalarField<64>, Q: BN254J, K:
 }
 
 unconstrained fn get_transcript(P: BN254J, scalar: ScalarField<64>) -> [AffineTranscript<Fq>; 326] {
-    let res = P.mul(scalar);
-    let transcript = res.1;
-    transcript.as_array()
+    let (_, transcript) = P.mul(scalar);
+    transcript
 }
 
 #[test]

diff --git a/src/curve_jac.nr b/src/curve_jac.nr
@@ -549,7 +549,7 @@ where
     pub(crate) unconstrained fn mul<let NScalarSlices: u32>(
         self,
         scalar: ScalarField<NScalarSlices>,
-    ) -> (Self, [AffineTranscript<BigNum>]) {
+    ) -> (Self, [AffineTranscript<BigNum>; 5 * NScalarSlices + 6]) {
         let mut transcript: [JTranscript<BigNum>; NScalarSlices * 5 + 6] =
             [JTranscript::new(); NScalarSlices * 5 + 6];
 
@@ -591,7 +591,7 @@ where
         ptr += 1;
         accumulator = op.0;
 
-        let affine_transcript: [AffineTranscript<BigNum>] =
+        let affine_transcript: [AffineTranscript<BigNum>; 5 * NScalarSlices + 6] =
             AffineTranscript::from_jacobian_transcript(transcript);
 
         (accumulator, affine_transcript)

diff --git a/src/lib.nr b/src/lib.nr
@@ -753,7 +753,7 @@ where
         P: Self,
         scalar: ScalarField<NScalarSlices>,
     ) -> [AffineTranscript<BigNum>; 6 + NScalarSlices * 5] {
-        CurveJ::from(P).mul(scalar).1.as_array()
+        CurveJ::from(P).mul(scalar).1
     }
 
     pub fn msm<let NScalarSlices: u32, let NMuls: u32>(