-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Install noir-profiler and noir-inspector #46
Conversation
.github/workflows/ci.yml
Outdated
- name: Check noir-profiler installation | ||
run: | | ||
if [ -f "${HOME}/.nargo/bin/noir-profiler" ]; then | ||
noir-profiler --version | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is a little tuatological. We're running noir-profiler --version
to check if it's there but only if it's there.
What I've done elsewhere in this workflow is to split the version number into major, minor, patch and we can then assert that after a certain version we expect the profiler to exist.
LGTM, let's merge this after 1.0.0-beta.3 goes out so we can test it with a |
Description
Problem*
Resolves #42
Summary*
This PR simply adds handling for installation of the noir-profiler from source. It uses the new tarball name
noir-{architecture}-{platform}
that contains all Noir binaries after noir-lang/noir#7443.Adding an additional binary requires a couple changes to be compatible with older versions of Noir. Most notably we do a check against
curl {new binary url}
to determine whether we need to use the old binary url name.When compiling from source we switched to checking whether a binary exists before attempting to move it.
Additional Context
We probably could also rename
.nargo
to.noir
as we now have Noir binaries that are not contained to just nargo. However, I feel we can do this switch later.PR Checklist*
cargo fmt
on default settings.