Skip to content

chore: consolidate fixed length poseidon function implementations #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomAFrench merged 11 commits into from
Jan 13, 2026
Merged

chore: consolidate fixed length poseidon function implementations #23

TomAFrench merged 11 commits into from
Jan 13, 2026

Conversation

@jialinli98
Copy link
Contributor

@jialinli98 jialinli98 commented Jan 12, 2026 •
edited
Loading

Description

Problem*

Resolves

Summary*

Added hash_internal helper function to reduce duplication.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jialinli98 jialinli98 changed the title improve last hash feat: compute only the first row of matrix multiplication in final round and consolidate functions Jan 12, 2026
@jialinli98 jialinli98 requested a review from TomAFrench January 12, 2026 07:49
@TomAFrench
Copy link
Member

TomAFrench commented Jan 12, 2026

Are we sure that this affects circuit size? I would expect that DIE would remove the extra instructions as they look to be pure.

@TomAFrench TomAFrench closed this Jan 12, 2026
@TomAFrench TomAFrench reopened this Jan 12, 2026
@jialinli98 jialinli98 changed the title feat: compute only the first row of matrix multiplication in final round and consolidate functions chore: compute only the first row of matrix multiplication in final round and consolidate functions Jan 13, 2026
TomAFrench
TomAFrench reviewed Jan 13, 2026
View reviewed changes
@TomAFrench TomAFrench changed the title chore: compute only the first row of matrix multiplication in final round and consolidate functions chore: consolidate fixed length poseidon function implementations Jan 13, 2026
@TomAFrench TomAFrench merged commit a901f3b into master Jan 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

Assignees

No one assigned

Labels

bench-show

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jialinli98 @TomAFrench