chore!: remove wrapping_add + update oracle testing + update benchmarks #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jialinli98
force-pushed
the
jl/remove_wrapping
branch
from
c73f662 to
b334fd9
Compare
jialinli98
force-pushed
the
jl/remove_wrapping
branch
2 times, most recently
from
5449ee5 to
83665d0
Compare
jialinli98
force-pushed
the
jl/remove_wrapping
branch
from
83665d0 to
e41d372
Compare
jialinli98
changed the title
jialinli98
force-pushed
the
jl/remove_wrapping
branch
from
3f689a8 to
f0a2515
Compare
5 tasks
asterite
approved these changes
Jan 13, 2026
Contributor
asterite
left a comment
asterite
left a comment
There was a problem hiding this comment.
Looks good! Though maybe the other changes should have gone in a separate PR?
Member
|
Agree that separate PRs for the testing + benchmarking changes is best. I'll merge this as is for now though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
closes #12
Summary*
Remove wrapping_add as it's getting deprecataed noir-lang/noir#11158 and update oracle testing and benchmarks
Additional Context
PR Checklist*
cargo fmton default settings.BEGIN_COMMIT_OVERRIDE
chore!: remove wrapping_add (#13)
chore: update oracle testing + benchmarks (#13)
END_COMMIT_OVERRIDE