Fixing Swagger Issue when using @api.expect() on a request parser#719
Open
tnweiss wants to merge 2 commits intonoirbizarre:masterfrom
tnweiss:master
Open
Fixing Swagger Issue when using @api.expect() on a request parser#719tnweiss wants to merge 2 commits intonoirbizarre:masterfrom tnweiss:master
tnweiss wants to merge 2 commits intonoirbizarre:masterfrom
tnweiss:master
Conversation
|
Great job, Thanks By the way, I found that def rparser_to_swagger_body_param(request_parser):
"""
If any parameters are in the request body then return the swagger representation for the requests json body
:param request_parser: The request parser containing params for the request
:return:
"""
json_body_list = [p for p in request_parser.__schema__ if p['in'] == 'body']
if not json_body_list:
return
properties = {}
for param in json_body_list:
properties[param['name']] = {
'type': 'string' if 'type' not in param else param['type']
}
return {
'name': 'payload',
'required': True,
'in': 'body',
'schema': {
'type': 'object',
'properties': properties
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Below is a request parser for a simple hello world server.
The resulting swagger JSON for these parameters is
The result should be something similar to when a user provides a model with api.expect()
These changes fix that bug.