Skip to content

feat: add emoji-click-sync event as Safari workaround#500

Merged
nolanlawson merged 8 commits into
masterfrom
emoji-click-sync
Sep 5, 2025
Merged

feat: add emoji-click-sync event as Safari workaround#500
nolanlawson merged 8 commits into
masterfrom
emoji-click-sync

Conversation

@nolanlawson

Copy link
Copy Markdown
Owner

Fixes #281

I really don't like adding additional API surface just to work around a Safari bug, but even if WebKit fixes it tomorrow, there will be old versions of Safari floating around for ages.

Adds a new event, emoji-click-sync, which does the same thing as emoji-click but is synchronous and its event.detail is a promise for the same detail object in the non-sync version.

@github-actions

github-actions Bot commented Sep 5, 2025

Copy link
Copy Markdown

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-change-tab: unsure 🔍 -4% - +4% (-1.39ms - +1.37ms)
    this-change vs tip-of-tree
  • emoji-picker-element-database-interactions: unsure 🔍 -3% - +3% (-3.74ms - +4.14ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -2% - +4% (-1.20ms - +2.24ms)
    this-change vs tip-of-tree
  • emoji-picker-element-many-custom-emoji: unsure 🔍 -5% - +3% (-5.93ms - +3.53ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -4% - +5% (-1.57ms - +2.19ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-change-tab
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
34.02ms - 36.07ms-unsure 🔍
-4% - +4%
-1.39ms - +1.37ms
tip-of-tree
tip-of-tree
34.13ms - 35.97msunsure 🔍
-4% - +4%
-1.37ms - +1.39ms
-
emoji-picker-element-database-interactions
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
121.24ms - 126.80ms-unsure 🔍
-3% - +3%
-3.74ms - +4.14ms
tip-of-tree
tip-of-tree
121.02ms - 126.61msunsure 🔍
-3% - +3%
-4.14ms - +3.74ms
-
emoji-picker-element-first-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
52.27ms - 54.74ms-unsure 🔍
-2% - +4%
-1.20ms - +2.24ms
tip-of-tree
tip-of-tree
51.79ms - 54.18msunsure 🔍
-4% - +2%
-2.24ms - +1.20ms
-
emoji-picker-element-many-custom-emoji
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
103.85ms - 110.56ms-unsure 🔍
-5% - +3%
-5.93ms - +3.53ms
tip-of-tree
tip-of-tree
105.07ms - 111.73msunsure 🔍
-3% - +6%
-3.53ms - +5.93ms
-
emoji-picker-element-second-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
42.43ms - 45.18ms-unsure 🔍
-4% - +5%
-1.57ms - +2.19ms
tip-of-tree
tip-of-tree
42.22ms - 44.77msunsure 🔍
-5% - +4%
-2.19ms - +1.57ms
-

tachometer-reporter-action v2 for Benchmarks

@github-actions

github-actions Bot commented Sep 5, 2025

Copy link
Copy Markdown

Size Change: +63 B (+0.17%)

Total Size: 37.4 kB

Filename Size Change
./bundle.js 37.4 kB +63 B (+0.17%)

compressed-size-action

@nolanlawson nolanlawson merged commit 476dbc3 into master Sep 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There is no way to copy emoji to the clipboard (Safari)

1 participant