Skip to content

fix: calculate emoji width correctly when hidden#526

Merged
nolanlawson merged 2 commits into
masterfrom
hidden-emoji
Mar 1, 2026
Merged

fix: calculate emoji width correctly when hidden#526
nolanlawson merged 2 commits into
masterfrom
hidden-emoji

Conversation

@nolanlawson

Copy link
Copy Markdown
Owner

Fixes #514

We fall back to a less performant emoji-width-calculation algorithm if the picker is hidden. This avoids needing to warn the user and potentially show broken results.

@github-actions

github-actions Bot commented Mar 1, 2026

Copy link
Copy Markdown

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-change-tab: unsure 🔍 -4% - +2% (-1.47ms - +0.59ms)
    this-change vs tip-of-tree
  • emoji-picker-element-database-interactions: unsure 🔍 -5% - +4% (-6.22ms - +5.22ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -4% - +2% (-2.08ms - +1.39ms)
    this-change vs tip-of-tree
  • emoji-picker-element-many-custom-emoji: unsure 🔍 -6% - +3% (-6.81ms - +2.93ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -5% - +3% (-2.44ms - +1.30ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-change-tab
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
32.92ms - 34.44ms-unsure 🔍
-4% - +2%
-1.47ms - +0.59ms
tip-of-tree
tip-of-tree
33.43ms - 34.82msunsure 🔍
-2% - +4%
-0.59ms - +1.47ms
-
emoji-picker-element-database-interactions
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
126.42ms - 134.78ms-unsure 🔍
-5% - +4%
-6.22ms - +5.22ms
tip-of-tree
tip-of-tree
127.19ms - 135.00msunsure 🔍
-4% - +5%
-5.22ms - +6.22ms
-
emoji-picker-element-first-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
55.70ms - 57.91ms-unsure 🔍
-4% - +2%
-2.08ms - +1.39ms
tip-of-tree
tip-of-tree
55.82ms - 58.49msunsure 🔍
-2% - +4%
-1.39ms - +2.08ms
-
emoji-picker-element-many-custom-emoji
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
101.46ms - 108.92ms-unsure 🔍
-6% - +3%
-6.81ms - +2.93ms
tip-of-tree
tip-of-tree
104.01ms - 110.26msunsure 🔍
-3% - +7%
-2.93ms - +6.81ms
-
emoji-picker-element-second-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
43.84ms - 46.25ms-unsure 🔍
-5% - +3%
-2.44ms - +1.30ms
tip-of-tree
tip-of-tree
44.18ms - 47.04msunsure 🔍
-3% - +5%
-1.30ms - +2.44ms
-

tachometer-reporter-action v2 for Benchmarks

@github-actions

github-actions Bot commented Mar 1, 2026

Copy link
Copy Markdown

Size Change: +76 B (+0.2%)

Total Size: 37.9 kB

Filename Size Change
./bundle.js 37.9 kB +76 B (+0.2%)

compressed-size-action

@nolanlawson nolanlawson merged commit 62d423a into master Mar 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Several emojis missing when using an initially hidden <emoji-picker>

1 participant