fix(encoding,ci): silence self-healing warmup 503 alert + robust E2E result check#790
Merged
beveradb merged 1 commit intoMay 24, 2026
Conversation
…E2E result check robust
Two unrelated alert-noise fixes:
- Encoding worker /warmup endpoint now logs EncodingWorkerStartError
(capacity exhaustion / transient 503) at WARNING instead of ERROR.
The encoding flow's ensure_any_running() falls back to alternate-zone
workers, so a primary-VM 503 is self-healing and should not trip the
error monitor (severity>=ERROR) or page Discord. Genuine unexpected
failures still log at ERROR.
- E2E daily test (both stages) now determines pass/fail from Playwright's
real exit code (captured via PIPESTATUS[0], since the pipe to tee masked
it as 0) instead of grepping the log. The old grep matched the word
"failed" inside benign retry warnings ("goto attempt 1/3 failed"),
reporting failure on runs where the job completed and Playwright passed.
Adds 3 regression tests for warmup log severity. Updates TROUBLESHOOTING.md.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two unrelated production alert-noise fixes, prompted by two false-alarm Discord alerts on 2026-05-24:
503 SERVICE_UNAVAILABLE(or capacity exhaustion) is self-healing — the encoding flow'sensure_any_running()falls back to an alternate-zone worker and the job completes (verified live on joba40f3024). It no longer logs at ERROR, so it stays below the error monitor'sseverity>=ERRORfilter and stops paging Discord for a non-incident."failed". The old check matched the word "failed" inside a benign retry warning (goto attempt 1/3 failed) and reported failure on a run where the job completed and Playwright printed1 passed.Changes
backend/api/routes/encoding_worker.py— catchEncodingWorkerStartErrorin/warmupand log at WARNING with a clear fallback message; genuine unexpected errors still log at ERROR..github/workflows/e2e-daily.yml— capture${PIPESTATUS[0]}(the pipe toteewas masking Playwright's exit code as 0) and gate the result on it, for both Stage 1 and Stage 2.backend/tests/test_encoding_worker_routes.py— 3 regression tests: 503 start failure → WARNING, capacity error → WARNING, unexpected error → still ERROR.docs/TROUBLESHOOTING.md— note that a WARNING-level warmup 503 is benign/self-healing.pyproject.toml— bump 0.174.11 → 0.174.12.Testing
pytest backend/tests/test_encoding_worker_routes.py backend/tests/test_encoding_worker_manager.py— 46 passedReview
@coderabbitai ignore
🤖 Generated with Claude Code