Skip to content

Conversation

@zbear0808
Copy link
Contributor

@zbear0808 zbear0808 commented May 3, 2025

Changes

add directml for pytorch
add directml for onnxruntime
add dependencies to project toml
make the use of directml optional

testing

I tried these 2 models

model = "MDX23C-DrumSep-aufr33-jarredou.ckpt"
model = "UVR-DeEcho-DeReverb.pth"

only the drum separation model worked. The 2nd failed due to the aten::_thnn_fused_lstm_cell operator not existing on the directml backend yet. Maybe it's possible to rebuild these models using a more limited operation set, but that's probably not worth the effort
but also, these same models work in UVR beta, I can't figure out what's different, but ig at least i got some stuff to work.

notes

by default the commandline script and Separator class object will try to use cuda if it's available, but will not do the same for directml.
according to UVR directml is experimental, and the torch_directml library is only in the pre-release stage .

I've only tested this on 2 models on an AMD Radeon 780M (integrated laptop GPU)

@zbear0808 zbear0808 marked this pull request as ready for review May 3, 2025 07:01
@zbear0808
Copy link
Contributor Author

@beveradb have you taken a look at this yet?

@beveradb beveradb merged commit de321c5 into nomadkaraoke:main May 20, 2025
13 checks passed
@beveradb
Copy link
Collaborator

Nah I hadn't, sorry for the delay @zbear0808 just been busy with my day job.
I don't use Windows but thank you for the contribution, hopefully it helps some folks! 😄
Should be released in v0.34 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants