Remove unnecesary validations#20
Merged
maxd-nordic merged 1 commit intonordicsemi:mainfrom May 12, 2025
Merged
Conversation
maxd-nordic
reviewed
May 12, 2025
Comment on lines
90
to
91
| if credstore.delete(args.tag, ct): | ||
| print(f'{ct.name} in secure tag {args.tag} deleted') |
Contributor
There was a problem hiding this comment.
Suggested change
| if credstore.delete(args.tag, ct): | |
| print(f'{ct.name} in secure tag {args.tag} deleted') | |
| credstore.delete(args.tag, ct) |
Collaborator
Author
There was a problem hiding this comment.
I decided to keep the feedback because it acknowledge that you have successfully deleted the sectag, otherwise it prints the error. Without it, if success you don't get anything printed
Signed-off-by: Pascal Hernandez <pascal.hernandez@nordicsemi.no>
pascal-nordic
force-pushed
the
remove-unnecesary-code
branch
from
6ba6142 to
37949cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error handling is managed in at_client.py so there is no need to validate again errors in other parts of the code