Merged
Conversation
Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
maxd-nordic
force-pushed
the
comms-integration
branch
from
0ebc136 to
52cfe33
Compare
| (r"0010550", "Thingy:91 X", 0), | ||
| (r"0010551", "Thingy:91 X", 0), | ||
| (r"0010513", "Thingy:91 X", 0), | ||
| (r"0010577", "nRF54L15-DK", 1), |
Collaborator
There was a problem hiding this comment.
Why are we supporting nRF54 devices?
Contributor
Author
There was a problem hiding this comment.
They can also be used for as a host for an nRF70, at least in theory.
pascal-nordic
approved these changes
Jul 1, 2025
Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
gregersrygg
approved these changes
Jul 4, 2025
Contributor
gregersrygg
left a comment
gregersrygg
left a comment
There was a problem hiding this comment.
Great improvements 🎉
Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
gregersrygg
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate comms and command_interface modules from nrfcloud-utils. After this, they will be removed from nrfcloud-utils and nrfcredstore is used as a dependency. New test suites are provided to make imported modules more robust. Some changes were made to the modules to integrate them.
This adds the following features: