Improve error logging #25
Merged
Merged
Conversation
gregersrygg
approved these changes
Jan 9, 2026
pascal-nordic
force-pushed
the
Improve-error-logging
branch
from
26343f0 to
7c9f649
Compare
application. The exception was not user friendly. Signed-off-by: Pascal Hernandez <pascal.hernandez@nordicsemi.no>
pascal-nordic
force-pushed
the
Improve-error-logging
branch
from
7c9f649 to
68ee004
Compare
maxd-nordic
reviewed
Jan 12, 2026
| code = int(line.replace('+CME ERROR: ', '')) | ||
| # Parse error code if present, otherwise use -1 for unknown | ||
| try: | ||
| code_str = line.replace('+CME ERROR:', '').strip() |
Contributor
There was a problem hiding this comment.
it would be interesting to have an example for a CME ERROR line that cannot be parsed. I guess that happens when logs are interleaved because of timing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exception displayed in case there is a timeout when trying to identify what type of communication to have with the device is not user-friendly. This PR look to improve it.