Fix "Recover" button wrap#598
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
SlavaNordic
added
doc not required
SlavaNordic
temporarily deployed
to
release-test (internal)
GitHub Actions
Inactive
kylebonnici
previously approved these changes
May 11, 2026
Contributor
|
IMO we should let buttons take their natural width and not fore both to be same width. @tsvetelinpetrov @datenreisender can you give your input |
Contributor
Author
|
Agree with @kylebonnici, not sure why we wanted same 60px width. Maybe this was Ketil's feedback. |
Contributor
I also don't remember what was the reasoning for the fixed width, but I agree with @kylebonnici. |
Contributor
|
I also prefer to let the buttons have their natural width here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://nordicsemi.atlassian.net/browse/NCD-1647
Reason for this to happen is that Button component has
tw-border tw-border-nordicBlueclasses, for some reason they did not appear in classes with older shared but appear now.Just added a bit of a width to allow text to fit into the box. Almost no visual difference.
PR also adds white border, because current border is same as bg color => visually button height is smaller than it should be