Cleanup workflow to notify swtools-app-docs workflow#606
Merged
Conversation
The 'on: release' trigger would cause too many runs of the docs-notify-swtools-repo.yml workflow: - When a release is created through the release.yml workflow, the docs-notify-swtools-repo.yml workflow is already triggered explicitly, so that trigger would cause the workflow to run twice. - When a pre-release is created manually, the trigger would also cause the workflow to run, which is probably not intended. Removing this trigger also simplifies the rest of the workflow.
This comment has been minimized.
This comment has been minimized.
datenreisender
added
doc not required
There was a problem hiding this comment.
Pull request overview
This PR cleans up the GitHub Actions workflow used to notify the swtools-app-docs repository about a new pc-nrfconnect-ppk release, shifting the workflow toward being called explicitly with a ref and simplifying tag derivation from package.json.
Changes:
- Simplified
docs-notify-swtools-repo.ymlby removing thereleaseevent trigger and inline release-tag resolution, and instead deriving the tag frompackage.json. - Updated
release.ymlto pass only${{ inputs.ref }}to the notification workflow (removing the previous fallback behavior). - Adjusted the GitHub App token step configuration (but currently with an incompatible input name).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/release.yml |
Updates how the notify workflow is invoked, passing along the ref input directly. |
.github/workflows/docs-notify-swtools-repo.yml |
Simplifies notification workflow triggers and tag resolution; updates checkout behavior and GitHub App token creation inputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
When invoking docs-notify-swtools-repo.yml manually, one should always provide an explicit ref.
datenreisender
force-pushed
the
push-wwrorxroqzts
branch
from
c59bce3 to
9482f5a
Compare
KievDevel
approved these changes
May 25, 2026
SlavaNordic
previously approved these changes
May 25, 2026
Because it was renamed in nordicsemi/swtools-app-docs#60.
datenreisender
force-pushed
the
push-wwrorxroqzts
branch
from
9482f5a to
03e4dc4
Compare
datenreisender
force-pushed
the
push-wwrorxroqzts
branch
from
03e4dc4 to
dfff9bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should eventually be moved to shared, probably replacing the code at the end of
release-app.yml. But before that I want to clean it up here.