Explicitly list GuiPrivate as dependency, for Qt 6.10#124
Closed
jonhermansen wants to merge 1 commit intonorihiro:mainfrom
Closed
Explicitly list GuiPrivate as dependency, for Qt 6.10#124jonhermansen wants to merge 1 commit intonorihiro:mainfrom
jonhermansen wants to merge 1 commit intonorihiro:mainfrom
Conversation
13 tasks
norihiro
added a commit
to noris-plugins-for-obs/noriscommonui
that referenced
this pull request
Nov 11, 2025
According to the PR below, NixOS requires to have find Qt::GuiPrivate package intentionally. - norihiro/obs-color-monitor#124 In addition, this commit includes these related changes. - Call `find_package` even inside another directory - Require Qt::GuiPrivate only for Linux
norihiro
added a commit
to noris-plugins-for-obs/noriscommonui
that referenced
this pull request
Nov 11, 2025
According to the PR below, NixOS requires to find Qt::GuiPrivate package intentionally. - norihiro/obs-color-monitor#124 In addition, this commit includes these related changes. - Call `find_package` even inside another directory - Require Qt::GuiPrivate only for Linux
Owner
|
Thank you for making the PR. I'm re-structuring the code that uses Qt::GuiPrivate in my other PR #122. I took your error case into account for my change. So, could you try the code #122 on your environment? (I tried to reproduce the error on NixOS but it looks too complicated for me to start using NixOS.) git switch separate-noriscommonui
git submodule init |
Contributor
|
This plugin is not building on Debian Sid either. |
4 tasks
Owner
|
Released version 0.9.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that this plugin no longer builds on NixOS with Qt 6.10:
The fix was described here
I think the change is not backwards compatible with older versions of Qt.
How Has This Been Tested?
Launched OBS 32.0.1 under Sway, capturing screen via dmabuf. Added histogram source and changed the captured colors to see the histogram change.
I'm new to this plugin, so I may not have tested all features well. I just wanted to get the plugin building again, but I think the patch is correct.
General checklist