List crafting recipes in skill page#217
Open
AlexMooney wants to merge 6 commits intonornagon:mainfrom
Open
Conversation
Owner
|
Generally we use <LimitedList> for this type of UI, I'd like to stay consistent rather than introducing this detail view. |
Author
|
Hey @nornagon. Sorry I took so long to get to your feedback. I've cleaned up both PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the skill pages, show all of the crafts and how to learn them grouped by difficulty level.
Some of the Electronics stuff:
Section is skipped if there are no recipes:
Books are not listed if there are >2. Never learn recipes are excluded.
This was written by an AI agent. I don't know svelte or typescript but I linted it and tested it locally.