santactl/fileinfo: Change how Rule field is populated#436
Merged
Conversation
github-actions
Bot
added
comp/santad
russellhancox
added
the
💣 breaking
tburgin
previously approved these changes
Jun 12, 2025
tburgin
left a comment
tburgin
left a comment
Contributor
There was a problem hiding this comment.
This is a welcome refactor.
mlw
requested changes
Jun 12, 2025
mlw
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of showing the decision that would (probably) be made by santad, the
Rulefield now shows which rule matches. This more accurately reflects the field name and allows us to show that a CEL rule exists (which largely precludes being able to actually give a decision). If we wanted, we could later expand on this to alsoThis involved removing the (now unneeded)
decisionForFilePath:identifiers:reply:method from the XPC control interface, and moving thedatabaseRuleForIdentifiers:reply:method from the privileged to the unprivileged interface. I also moved astringifyRule:withColor:method that had been in SNTCommandRule into SNTRule itself so it can easily be used by both commands.