Skip to content

Sync the chrome cookies example on the FAA page#871

Merged
mlw merged 3 commits into
mainfrom
mlw/faa-cookies-example
Mar 26, 2026
Merged

Sync the chrome cookies example on the FAA page#871
mlw merged 3 commits into
mainfrom
mlw/faa-cookies-example

Conversation

@mlw
Copy link
Copy Markdown
Contributor

@mlw mlw commented Mar 26, 2026

Synchronize the FAA cookies example with the one on the cookbook.

Long term we will want to have a more generic example to not need to keep things in sync like this. But patching for now so that the information is correct.

image

@mlw mlw added this to the 2026.3 milestone Mar 26, 2026
@mlw mlw requested a review from a team as a code owner March 26, 2026 02:22
@github-actions github-actions Bot added docs Improvements or additions to documentation size/s Size: small labels Mar 26, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 28d04343-73c3-4c11-994e-15757eee58f1

📥 Commits

Reviewing files that changed from the base of the PR and between 30e5b24 and 1971a79.

📒 Files selected for processing (1)
  • docs/docs/features/faa.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/docs/features/faa.md

📝 Walkthrough

Walkthrough

Updated FAA docs example "Protecting Browser Cookies (Data-centric)": Chrome helper SigningID match changed from com.google.Chrome.helper to com.google.Chrome* (wildcard), and a new macOS 26.3+ process exception for SigningID com.apple.mds with PlatformBinary: true was added.

Changes

Cohort / File(s) Summary
FAA Documentation
docs/docs/features/faa.md
Modified the "Protecting Browser Cookies (Data-centric)" example: changed Chrome process SigningID match from com.google.Chrome.helper to wildcard com.google.Chrome* and added a new com.apple.mds process <dict> entry with SigningID: com.apple.mds and PlatformBinary: true (macOS 26.3+).

Sequence Diagram(s)

(omitted — documentation-only change)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly references syncing the Chrome cookies example on the FAA page, which aligns with the PR's primary change of updating the documentation example.
Description check ✅ Passed The description explains the purpose of synchronizing the FAA cookies example with the cookbook example and acknowledges the longer-term plan, clearly relating to the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mlw/faa-cookies-example

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
docs/docs/features/faa.md (1)

248-248: Small wording fix: “files system” → “file system”.

Line 248 has a typo in user-facing docs.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/docs/features/faa.md` at line 248, Fix the typo in the user-facing
documentation by replacing the phrase "files system" with "file system" in the
docs/docs/features/faa.md content (search for the exact string "files system" to
locate the occurrence).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@docs/docs/features/faa.md`:
- Line 248: Fix the typo in the user-facing documentation by replacing the
phrase "files system" with "file system" in the docs/docs/features/faa.md
content (search for the exact string "files system" to locate the occurrence).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 46110ddc-225c-4188-8776-165718e026b6

📥 Commits

Reviewing files that changed from the base of the PR and between 8fceee0 and d07a396.

📒 Files selected for processing (1)
  • docs/docs/features/faa.md

Comment thread docs/docs/features/faa.md Outdated
Comment thread docs/docs/features/faa.md Outdated
@mlw mlw requested a review from russellhancox March 26, 2026 13:18
@mlw mlw merged commit 8b2b3f0 into main Mar 26, 2026
4 checks passed
@mlw mlw deleted the mlw/faa-cookies-example branch March 26, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation size/s Size: small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants