gui: Fix keyboard shortcuts for closing windows#941
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR updates keyboard shortcuts for dismiss buttons across message window views, standardizing to cancelAction/Esc patterns or Cmd+W, and adds URL fallback logic in the Binary display test harness to prefer eventDetailURL when customURL is absent. ChangesDismiss Keyboard Shortcuts and URL Fallback
🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
mlw
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For notification windows, the existing Cmd+Esc doesn't work and I couldn't find a way to reliably make it work. Switch to Cmd+W instead.
For the More Info pane, switch from Cmd+Esc to just plain Esc.
Also fix the passing of EventDetailURL in SNTTestGUI.