Skip to content

sync: Remove debug log that prints CEL fallback expressions#971

Merged
mlw merged 1 commit into
mainfrom
mlw/snt-418-remove-sync-debug-log-that-prints-cel-fallback-expressions
May 26, 2026
Merged

sync: Remove debug log that prints CEL fallback expressions#971
mlw merged 1 commit into
mainfrom
mlw/snt-418-remove-sync-debug-log-that-prints-cel-fallback-expressions

Conversation

@mlw
Copy link
Copy Markdown
Contributor

@mlw mlw commented May 26, 2026

Removes the SLOGD line in SNTSyncPreflight.mm that printed CEL fallback rule expressions (and their custom message / URL) to the sync debug log on every preflight.

Fixes SNT-418.

@mlw mlw requested a review from a team as a code owner May 26, 2026 16:30
@github-actions github-actions Bot added comp/santasyncservice Issues or PRs related to the sync protocol lang/objc++ PRs modifying files in ObjC++ size/xs Size: extra small labels May 26, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c0a65225-45e3-4eaa-a3cb-aefcaaf0c865

📥 Commits

Reviewing files that changed from the base of the PR and between d526b99 and 4519544.

📒 Files selected for processing (1)
  • Source/santasyncservice/SNTSyncPreflight.mm
💤 Files with no reviewable changes (1)
  • Source/santasyncservice/SNTSyncPreflight.mm

📝 Walkthrough

Walkthrough

This PR removes a per-rule debug logging statement from the CEL fallback rule processing loop in SNTSyncPreflight.mm. The rule conversion, object creation, and aggregation logic remain intact; only verbose per-iteration debug output is eliminated.

Changes

CEL Fallback Rules Debug Logging Removal

Layer / File(s) Summary
Remove per-rule debug logging
Source/santasyncservice/SNTSyncPreflight.mm
The per-iteration debug log call that printed each CEL fallback rule's expression and optional message/URL is removed from the processing loop; rule conversion and addition to syncState.celFallbackRules remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • northpolesec/santa#907: Both PRs remove verbose per-rule debug logging from CEL fallback rule processing while preserving the underlying conversion and evaluation logic.
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing a debug log that prints CEL fallback expressions, which matches the changeset.
Description check ✅ Passed The description is directly related to the changeset, explaining the specific debug log removal and referencing the associated issue (SNT-418).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mlw/snt-418-remove-sync-debug-log-that-prints-cel-fallback-expressions

Comment @coderabbitai help to get the list of available commands and usage tips.

@mlw mlw merged commit 95066c5 into main May 26, 2026
8 checks passed
@mlw mlw deleted the mlw/snt-418-remove-sync-debug-log-that-prints-cel-fallback-expressions branch May 26, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/santasyncservice Issues or PRs related to the sync protocol lang/objc++ PRs modifying files in ObjC++ size/xs Size: extra small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants