Impl SerJson for HashMap<&str, T> and other types - #138
Open
Ameobea wants to merge 3 commits into
Open
Conversation
* Add an auto-impl for `SerJson` for `&T: SerJson`. This allows types like `HashMap<&'static str, &'static str>` and many others to serialize to JSON while they previously couldn't * Add a test to verify that `HashMap<&str, T>` can actually be serialized and produces correct results
Collaborator
|
@not-fl3 do you have any opinion on this? |
not-fl3
approved these changes
Jul 1, 2025
Contributor
|
Why is this in limbo? |
not-fl3
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was integrating
nanoserdein a project of mine but ran into difficulty when trying to serialize aHashMap<&'static str, MyStructThatImplsSerJson>to JSON. This was due to the fact thatstrimplementsSerJsonbut not&str.This fix makes it so that things work as expected for that case and many others too (
Vec<&str>,&[&usize], etc.)`Changes
SerJsonfor&T: SerJson. This allows types likeHashMap<&'static str, &'static str>and many others to serialize to JSON while they previously couldn'tHashMap<&str, T>can actually be serialized and produces correct results