Add test for and fix JSON serialization of tuple-like enum variants with a single field - #150
Merged
knickish merged 2 commits intoApr 12, 2026
Conversation
…ith a single field
knickish
force-pushed
the
json_single_field_enum_serialization
branch
from
February 7, 2026 22:00
22eaf84 to
dce06c7
Compare
knickish
marked this pull request as ready for review
February 7, 2026 22:00
not-fl3
approved these changes
Feb 9, 2026
|
This doesn't appear to apply the same logic to deserialization, which causes round-trips to fail as the deserializer still expects only an array for single-member tuples. |
…ld tuple-like enums
knickish
force-pushed
the
json_single_field_enum_serialization
branch
from
April 12, 2026 18:14
d2bc850 to
b4ed837
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #140