Fix trailing comma parsing in DeJson proc macro - #167
Open
tadeohepperle wants to merge 1 commit into
Open
Conversation
not-fl3
reviewed
Jul 25, 2026
| let mut wraps = vec![]; | ||
| let mut path = "(".to_owned(); | ||
| while let Some(next_ty) = next_type(source) { | ||
| while next_eof(source).is_none() { |
Owner
There was a problem hiding this comment.
I would either make a special combinator ignoring eof for this or would add an explicit eof check at the end of this while loop.
I also feel like next_exact_punct(source, ","). might have tried to fix the same problem?
First reaction after first glad at the code, if you want I can take a shot on implementing it later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #166