Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
pkgs/typed-api-specpackage, focusing on enhancing thefetchmodule's flexibility and correctness. The most important changes involve extending type definitions and updating test cases to reflect these improvements.Enhancements to type definitions:
pkgs/typed-api-spec/src/fetch/index.ts: AddedHeadersandBodytype parameters to theFetchTtype and introducedCanOmitMethodandCanOmitInitboolean type parameters to determine if theinitparameter can be omitted based on method and headers conditions. [1] [2]Updates to test cases:
pkgs/typed-api-spec/src/fetch/index.t-test.ts: Added new endpoint definitions and test cases to validate the behavior when headers are optional or required, and when methods other thangetare used. [1] [2]