Skip to content

Fix init omitting logic #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 5, 2025
Merged

Fix init omitting logic #163

merged 4 commits into from
Apr 5, 2025

Conversation

mpppk
Copy link
Collaborator

@mpppk mpppk commented Apr 5, 2025

This pull request includes several changes to improve type safety and documentation in the pkgs/docs/docs/04_client/overview.md and pkgs/typed-api-spec files. The most important changes include removing unnecessary parameters from fetch calls, adding a new And type, and updating the FetchT type to enforce stricter type checks.

Improvements to type safety in fetch calls:

Enhancements to type definitions and tests:

Updates to FetchT type:

Documentation improvements:

These changes collectively enhance the type safety and clarity of the codebase, making it easier to maintain and less prone to runtime errors.

@mpppk mpppk requested a review from Copilot April 5, 2025 04:20
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

type Spec = DefineApiEndpoints<{
"/users": {
get: {
// 本来、GETメソッドはbodyを持たないが、型エラーになることを確認するために定:w
Copy link
Preview

Copilot AI Apr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] There appears to be a typo in the comment ('定:w'); consider correcting it to '定義' to improve clarity.

Copilot uses AI. Check for mistakes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@mpppk mpppk merged commit a07ebe0 into main Apr 5, 2025
3 checks passed
@mpppk mpppk deleted the fix-init-omit branch April 5, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant