-
Notifications
You must be signed in to change notification settings - Fork 58
Modernise for macOS Catalina, take two #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change the deploy target to 10.15 - Applied all the recommended fixes The run script still fails, and there are lots of warnings.
Gotta go back and find the correct way to set the build number.
Window still doesn't open, but it's a start!
NSMenuItem as a protocol was deprecated a while back.
Contributor
|
I agree to all, however I'd still recommend moving to ARC. The CoreMIDI stuff could use a second glance but everything else is simply removing retain/release and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've gone back to the drawing board on #2 and #4, because I wasn't comfortable with the memory management changes from #2. At best they'll leak memory, and I suspect they'll cause crashes in edge cases.
I also spotted some changes that, while they fixed warnings, left holes in the associated functionality.
So I've gone back to master, and started fixing and pulling in changes bit by bit. Specifically, I:
There are still lots of deprecation warnings, some of which simply need code pulled across from #4, and some of which are trickier.
In particular:
Other things still do to:
Things to test:
Other puzzles:
/cc @danomatika