Skip to content

fix: fix staticcheck issues in the verifier pkg #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

qba73
Copy link
Contributor

@qba73 qba73 commented Apr 18, 2025

This PR:

Copy link

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.92%. Comparing base (02cc632) to head (3708324).

Files with missing lines Patch % Lines
verifier/verifier.go 42.85% 8 Missing ⚠️

❌ Your patch check has failed because the patch coverage (42.85%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #537   +/-   ##
=======================================
  Coverage   80.92%   80.92%           
=======================================
  Files          36       36           
  Lines        3355     3355           
=======================================
  Hits         2715     2715           
  Misses        493      493           
  Partials      147      147           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts
Copy link
Contributor

@qba73 Looks like the test coverage is below the patch target. Please see the Codecov report for details: #537 (comment)

@Two-Hearts Two-Hearts changed the title fix staticcheck issues in the verifier pkg fix: fix staticcheck issues in the verifier pkg Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants