feat: artifactType support in signature manifest
#542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts
requested review from
gokarnm,
JeyJeyGao,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
vaninrao10 and
yizha1
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #542 +/- ##
==========================================
+ Coverage 80.92% 81.31% +0.38%
==========================================
Files 36 36
Lines 3355 3350 -5
==========================================
+ Hits 2715 2724 +9
+ Misses 493 483 -10
+ Partials 147 143 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
reviewed
May 6, 2025
Comment on lines
+244
to
+256
| if image.ArtifactType == ArtifactTypeNotation && image.Config.MediaType == ocispec.MediaTypeEmptyJSON { | ||
| // 1. artifactType is "application/vnd.cncf.notary.signature", | ||
| // and config.mediaType is "application/vnd.oci.empty.v1+json" | ||
| node.ArtifactType = image.ArtifactType | ||
| } else if image.ArtifactType == "" && image.Config.MediaType == ArtifactTypeNotation { | ||
| // 2. artifacteType does not exist, | ||
| // and config.mediaType is "application/vnd.cncf.notary.signature" | ||
| node.ArtifactType = image.Config.MediaType | ||
| } else { | ||
| // not a valid Notary Project signature | ||
| logger.Infof("not a valid Notary Project signature with artifactType %q and config.mediaType %q", image.ArtifactType, image.Config.MediaType) | ||
| continue | ||
| } |
There was a problem hiding this comment.
It is better to have a switch statement on image.ArtifactType.
Note: node is not always a Notary Project signature. It can be a SBoM or other artifacts. We should not have info log for those artifacts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an implementation of the Notary Project spec notaryproject/specifications#325.
Resolves #540