Closed
Conversation
Add http.route, error.type, network.protocol.version, and client.address
span attributes. Include http.response.status_code, http.route, and
error.type in metric attributes. Fix span naming to use standard
{METHOD} {route} format. Add proper xref and dialyzer configuration
with warnings_as_errors.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… license Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kivraDawi
approved these changes
Mar 11, 2026
Contributor
Author
|
Closing — all changes from this PR were already merged to main via #8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http.route,error.type,network.protocol.version,client.address(with X-Forwarded-For/Forwarded header support)http.response.status_code,http.route,error.typeon duration/body size histograms{METHOD} {route}format (e.g.GET /users/:id) instead ofGET controller:actionwarnings_as_errors, xref checks, and dialyzer config with proper PLT setup (0 warnings across all tools)eqwalizer:dynamic/0→dynamic()in otel_metrics.hrl via pre-compile hook (OTP 28+ built-in type)Test plan
rebar3 compile— 0 warnings (warnings_as_errors)rebar3 xref— 0 warningsrebar3 dialyzer— 0 warnings🤖 Generated with Claude Code