feat: add span exclusion sampler and fix context handling#9
Merged
Taure merged 1 commit intonovaframework:mainfrom Mar 17, 2026
Merged
Conversation
Replace otel_ctx:clear() with otel_ctx:detach() to properly restore previous context after span termination. Add otel_nova_sampler for excluding server spans by name (e.g. health/metrics endpoints).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
otel_ctx:clear()withotel_ctx:detach(PrevCtxToken)interminate/3to properly restore previous OTel context instead of destroying itotel_nova_samplermodule implementingotel_samplerbehaviour for excluding server spans by name (e.g. health checks, metrics endpoints)opentelemetryas a main dependency (required forotel_samplerbehaviour)Sampler usage
{opentelemetry, [ {sampler, {parent_based, #{ root => {otel_nova_sampler, [<<"GET /metrics">>, <<"GET /healthz">>]} }}} ]}.Test plan
stream_handler_restores_context_on_terminate— verifies context is restored, not clearedotel_nova_sampler_SUITE— 3 tests (excludes matching server spans, records non-matching, records non-server spans even if name matches)rebar3 fmt --check— cleanrebar3 xref— 0 warningsrebar3 dialyzer— 0 warnings