Let browser handle parsing of urls before relaying #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThinLinc-Zeijlon
force-pushed
the
fix-sub-url-query
branch
from
7e68a7a to
3be5596
Compare
ThinLinc-Zeijlon
force-pushed
the
fix-sub-url-query
branch
6 times, most recently
from
92bc5d1 to
a780ec1
Compare
We don't want to assign a path directly to url.pathname that contains a search query, since this causes '?' at the beginning of the query to be URL-encoded to '%3F'. Instead use URL() to parse the path for us.
ThinLinc-Zeijlon
force-pushed
the
fix-sub-url-query
branch
from
a780ec1 to
045a0ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently there is some magic happening under the surface when the
path-string containing a search query is assigned tourl.pathname.This is what caused
?to be translated to%3F.