Enable attaching the control bar to top and bottom#2043
Open
tobfah wants to merge 9 commits intonovnc:masterfrom
Open
Enable attaching the control bar to top and bottom#2043tobfah wants to merge 9 commits intonovnc:masterfrom
tobfah wants to merge 9 commits intonovnc:masterfrom
Conversation
added 9 commits
February 18, 2026 13:56
In preparation for top and bottom modes
Facilitates a horizontal control bar
Facilitates a horizontal control bar
Simplifies alignment for vertical and horizontal control bar modes
There's only one button in the group, and the wrapping div messed with the flex box layout
tobfah
force-pushed
the
enable-horizontal-control-bar
branch
from
edbef63 to
3b0ba39
Compare
|
Tested the implementation on Epiphany v40.2 and Chromium v144 on Fedora 43 and found no issues. Regarding the decision to not use a relative offset for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables attaching the control bar to the top and bottom positions, in addition to the traditional left and right positions.
Tested on