Fix three bugs: homepage in release.yml, failedSteps constant, filterFields helper#8
Merged
Conversation
- release.yml: restore homepage input to dispatch-formula job, dropped when migrating from inline dispatch to reusable workflow (issue #5) - build_view.go: introduce fieldFailedSteps constant to give the three runtime uses of "failedSteps" a single rename point (issue #6) - jsonout.go: extract filterFields helper to eliminate duplicated filter loop between printJSON and printJSONObject (issue #7) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 task
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
homepageinput todispatch-formulajob, dropped during reusable-workflow migration (88982f4).source_repowas patched back in the very next commit, confirminghomepagewas an oversight. Without it the Homebrew formula either fails dispatch (if required) or silently loses its homepage URL.const fieldFailedSteps = "failedSteps"and replace the three bare string literals (lines 71, 83, 115) with it. Renaming the JSON key previously had no compiler coverage; a missed site would silently drop failed-step output frombr build view.filterFields(row, requested)helper and remove the duplicated filter loop fromprintJSONandprintJSONObject. Single point of change for filter semantics.Test plan
go test ./...passesbr build view <failed-build>shows failed steps in human outputbr build view <n> --json status,buildNumber,failedStepsreturns correct JSONbr build list --json status,buildNumberstill filters correctlydispatch-formulajob includeshomepageCloses #5, #6, #7
🤖 Generated with Claude Code