Skip to content

fix(dashboard): open agent connector dropdown at top level fixes NV-7829#11338

Merged
LetItRock merged 3 commits into
nextfrom
cursor/fix-agent-connector-dropdown-7eef
May 29, 2026
Merged

fix(dashboard): open agent connector dropdown at top level fixes NV-7829#11338
LetItRock merged 3 commits into
nextfrom
cursor/fix-agent-connector-dropdown-7eef

Conversation

@LetItRock
Copy link
Copy Markdown
Contributor

@LetItRock LetItRock commented May 28, 2026

Summary

When creating an agent, the "Where do you want your agent?" dropdown opened directly on the integrations sub-view (credentials / existing integrations) for the currently selected managed connector. Users only saw options like "Setup Anthropic credentials" and the demo credential—not the full connector list (Claude Managed, AWS Claude Managed, custom code, etc.).

This change opens the dropdown at the top-level connectors view so all runtime options are visible on first open. Selecting a managed connector still navigates into the integrations sub-view as before.

Root cause

ConnectorIntegrationDropdown defaulted to integrations view whenever the selected connector had a providerId, including on every popover open.

Test plan

  • Open Agents → Add agent
  • Click Where do you want your agent?
  • Confirm External connectors lists Claude Managed Agent, AWS Claude Managed Agent, coming-soon options, and Custom code
  • Select AWS Claude Managed Agent → confirm integrations sub-view still works
  • Use back arrow → confirm connector list returns

Linear Issue: NV-7829

Open in Web Open in Cursor 

What changed

The ConnectorIntegrationDropdown component was modified to open at the top-level connectors view instead of defaulting to the integrations sub-view. The component now initializes its view state to 'connectors' and unconditionally resets to this state when the popover opens, rather than selecting based on whether the selected connector has a providerId. This ensures users see the complete list of connector options (Claude Managed, AWS Claude Managed, custom code, etc.) on first open.

Affected areas

  • dashboard: Modified the connector integration dropdown component to fix the initial view state and ensure the popover always opens at the top-level connectors list.

Testing

Manual testing is outlined in the PR description (open agents, verify connector list visibility, confirm navigation between views works correctly). No automated tests were added to this change.

Review Change Stack

Screen.Recording.2026-05-29.at.12.34.41.mov

Co-authored-by: Paweł Tymczuk <LetItRock@users.noreply.github.com>
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 28, 2026

PR author is not in the allowed authors list.

@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 28, 2026

NV-7829

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

📝 Walkthrough

Walkthrough

ConnectorIntegrationDropdown changes its initial view state and popover open-reset behavior to consistently start on the connectors view instead of conditionally choosing based on the selected connector's providerId.

Changes

Connector Integration Dropdown View State

Layer / File(s) Summary
Dropdown view initialization and reset behavior
apps/dashboard/src/components/agents/connectors/connector-integration-dropdown.tsx
Initial view state now defaults to 'connectors', and the popover open effect unconditionally resets view to 'connectors' instead of conditionally choosing based on selectedConnector.providerId.

🎯 2 (Simple) | ⏱️ ~8 minutes

@novu/dashboard

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows Conventional Commits format with valid type (fix) and scope (dashboard), includes a descriptive imperative statement, and correctly ends with the Linear ticket reference (fixes NV-7829).
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 28, 2026

Deploy preview added

Name Link
🔨 Latest commit 25b2ddb
🔍 Latest deploy log https://app.netlify.com/projects/dashboard-v2-novu-staging/deploys/6a1965d1992c4f0008739ca1
😎 Deploy Preview https://deploy-preview-11338.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

@LetItRock LetItRock marked this pull request as ready for review May 29, 2026 10:35
@LetItRock LetItRock merged commit a91749e into next May 29, 2026
36 checks passed
@LetItRock LetItRock deleted the cursor/fix-agent-connector-dropdown-7eef branch May 29, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants