feat(api-service): patch subscriber preferences v2 endpoint #7629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChmaraX
commented
Jan 30, 2025
| @@ -51,61 +46,44 @@ describe('Get Subscriber Preferences - /subscribers/:subscriberId/preferences (G | |||
| expect(response.statusCode).to.equal(404); | |||
| }); | |||
|
|
|||
| it('should handle subscriber with modified workflow preferences', async () => { | |||
There was a problem hiding this comment.
I removed GET&PATCH overlapping tests from GET endpoint and replaced them with tests testing unique GET behaviour
@novu/client
@novu/node
@novu/headless
@novu/notification-center
novu
@novu/providers
@novu/shared
commit: |
SokratisVidros
approved these changes
Jan 31, 2025
| channels: PatchPreferenceChannelsDto; | ||
|
|
||
| @ApiProperty({ | ||
| description: 'If provided, update workflow specific preferences, otherwise update global preferences', |
LetItRock
approved these changes
Jan 31, 2025
1 task
…patchput-preferences-endpoint
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
BiswaViraj
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
TODO: