Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix security wrapping on public sdk #7630

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Conversation

tatarco
Copy link
Contributor

@tatarco tatarco commented Jan 31, 2025

What changed? Why was the change needed?

pass correctly parameters to make sure the public DX stays solid in light of an internal sdk

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for dashboard-v2-novu-staging failed. Why did it fail? →

Name Link
🔨 Latest commit 70d3219
🔍 Latest deploy log https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/679c50a4bed1e50008ec93b4

Copy link

Hey there and thank you for opening this pull request! 👋

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Your PR title is: Fix security wrapping on public sdk
It should be something like: feat(scope): Add fancy new feature

Details:

No release type found in pull request title "Fix security wrapping on public sdk ". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
  • ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit

Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for dev-web-novu failed. Why did it fail? →

Name Link
🔨 Latest commit 70d3219
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/679c50a4a51e0f0008cb8ec8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant