refactor(dal): remove soft delete in message collection #8073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated message deletion methods to use a single delete operation instead of deleteMany. - Removed the 'deleted' field from various DTOs and entities as part of the cleanup. - Enhanced the update services to handle message removal more efficiently. - Added enforcement of environment ID in message deletion queries. - Cleaned up imports and adjusted return types for consistency.
SokratisVidros
approved these changes
Apr 7, 2025
…usecounts-hook-soft-delete
commit: |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This reverts commit ec519e6.
…usecounts-hook-soft-delete
SokratisVidros
approved these changes
Apr 8, 2025
scopsy
reviewed
Apr 14, 2025
Comment on lines
+125
to
+139
| messageSchema.pre('find', function filterDeletedFind() { | ||
| this.where({ deleted: { $ne: true } }); | ||
| }); | ||
| messageSchema.pre('findOne', function filterDeletedFindOne() { | ||
| this.where({ deleted: { $ne: true } }); | ||
| }); | ||
| messageSchema.pre('findOneAndUpdate', function filterDeletedFindOneAndUpdate() { | ||
| this.where({ deleted: { $ne: true } }); | ||
| }); | ||
| messageSchema.pre('countDocuments', function filterDeletedCountDocuments() { | ||
| this.where({ deleted: { $ne: true } }); | ||
| }); | ||
| messageSchema.pre('count', function filterDeletedCount() { | ||
| this.where({ deleted: { $ne: true } }); | ||
| }); |
There was a problem hiding this comment.
Just to verify, that's the proper syntax? Just looks a bit weird. Shouldn't we return something here?
There was a problem hiding this comment.
it is i tested it locally, but we will still need to double test in staging
There was a problem hiding this comment.
So this just adds another where clause right? Not overrides the existing one
scopsy
approved these changes
Apr 14, 2025
…usecounts-hook-soft-delete
djabarovgeorge
deleted the
nv-5647-investigate-high-response-time-with-usecounts-hook-soft-delete
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related tickets:
https://linear.app/novu/issue/NV-5647/investigate-high-response-time-with-usecounts-hook
https://linear.app/novu/issue/NV-5688/dalmessages-remove-backward-compatibility-logic-for-soft-delete
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer