Skip to content

feat(dashboard): Invalid variable pill improvements #8079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: next
Choose a base branch
from

Conversation

BiswaViraj
Copy link
Member

What changed? Why was the change needed?

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

linear bot commented Apr 7, 2025

Copy link

netlify bot commented Apr 7, 2025

Deploy Preview for dashboard-v2-novu-staging failed. Why did it fail? →

Name Link
🔨 Latest commit ecee771
🔍 Latest deploy log https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/67f7790429d5d500081a3f0a

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

apps/dashboard/src/utils/liquid-autocomplete.ts:275

  • The wrapping logic conditionally appends punctuation, which could lead to inconsistent formatting of inserted variables. Please verify that when isInvalidValue is true, skipping the closing brackets or adding a dot is the intended behavior.
const wrappedValue = `${needsOpening ? '{{' : ''}${selectedValue}${isInvalidValue && !selectedValue.endsWith('.') ? '.' : ''}${needsClosing && !isInvalidValue ? '}}' : ''}`;

apps/dashboard/src/components/workflow-editor/steps/email/maily.tsx:226

  • [nitpick] Concatenating the dynamic path root with a trimmed query may produce unexpected variable names when the query is empty. Consider adding a condition to only append the query if it is non-empty to ensure fully qualified suggestions.
name: value + query.trim(),

@BiswaViraj BiswaViraj force-pushed the nv-5616-do-not-create-pill-for-payload-or-stepsdigesteventspayload-pill branch from 92d00e2 to 989bad8 Compare April 7, 2025 11:56
@SokratisVidros SokratisVidros force-pushed the nv-5616-do-not-create-pill-for-payload-or-stepsdigesteventspayload-pill branch from 989bad8 to a4d40de Compare April 7, 2025 13:56
@SokratisVidros SokratisVidros force-pushed the nv-5616-do-not-create-pill-for-payload-or-stepsdigesteventspayload-pill branch from a4d40de to 4ad6eb6 Compare April 7, 2025 14:18
@BiswaViraj BiswaViraj force-pushed the nv-5616-do-not-create-pill-for-payload-or-stepsdigesteventspayload-pill branch from 4ad6eb6 to 21f3d66 Compare April 7, 2025 14:54
@SokratisVidros SokratisVidros force-pushed the nv-5616-do-not-create-pill-for-payload-or-stepsdigesteventspayload-pill branch from 21f3d66 to 18d5365 Compare April 7, 2025 14:59
@SokratisVidros SokratisVidros force-pushed the nv-5616-do-not-create-pill-for-payload-or-stepsdigesteventspayload-pill branch from 742c781 to be62a54 Compare April 8, 2025 17:15
@SokratisVidros SokratisVidros force-pushed the nv-5616-do-not-create-pill-for-payload-or-stepsdigesteventspayload-pill branch from be62a54 to eda2d88 Compare April 8, 2025 17:22
@SokratisVidros SokratisVidros force-pushed the nv-5616-do-not-create-pill-for-payload-or-stepsdigesteventspayload-pill branch from eda2d88 to ecee771 Compare April 10, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants