-
Notifications
You must be signed in to change notification settings - Fork 4k
feat(dashboard): Invalid variable pill improvements #8079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BiswaViraj
wants to merge
7
commits into
next
Choose a base branch
from
nv-5616-do-not-create-pill-for-payload-or-stepsdigesteventspayload-pill
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(dashboard): Invalid variable pill improvements #8079
BiswaViraj
wants to merge
7
commits into
next
from
nv-5616-do-not-create-pill-for-payload-or-stepsdigesteventspayload-pill
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for dashboard-v2-novu-staging failed. Why did it fail? →
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
apps/dashboard/src/utils/liquid-autocomplete.ts:275
- The wrapping logic conditionally appends punctuation, which could lead to inconsistent formatting of inserted variables. Please verify that when isInvalidValue is true, skipping the closing brackets or adding a dot is the intended behavior.
const wrappedValue = `${needsOpening ? '{{' : ''}${selectedValue}${isInvalidValue && !selectedValue.endsWith('.') ? '.' : ''}${needsClosing && !isInvalidValue ? '}}' : ''}`;
apps/dashboard/src/components/workflow-editor/steps/email/maily.tsx:226
- [nitpick] Concatenating the dynamic path root with a trimmed query may produce unexpected variable names when the query is empty. Consider adding a condition to only append the query if it is non-empty to ensure fully qualified suggestions.
name: value + query.trim(),
92d00e2
to
989bad8
Compare
989bad8
to
a4d40de
Compare
ChmaraX
approved these changes
Apr 7, 2025
apps/dashboard/src/components/workflow-editor/steps/email/maily.tsx
Outdated
Show resolved
Hide resolved
a4d40de
to
4ad6eb6
Compare
4ad6eb6
to
21f3d66
Compare
21f3d66
to
18d5365
Compare
742c781
to
be62a54
Compare
be62a54
to
eda2d88
Compare
…nd enhance variable filtering
The new UX prepends payload to all unknown {{foo}} variables as the user types them.
eda2d88
to
ecee771
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer