feat(root): new deployment and rollback action #8126
+425
−328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… repository prefix
…ment and production builds
…deployment matrix
…dling in deployment workflow
…nd adjust repository prefix
…e ECS deployment steps
|
Rollback Action |
…ate environment description
…f input for clarity
merrcury
changed the title
| if [ "${{ github.event.inputs.environment }}" == "development" ]; then | ||
| envs+=("\"development\"") | ||
| if [ "${{ github.event.inputs.environment }}" == "staging" ]; then | ||
| envs+=("\"staging-eu\"") |
There was a problem hiding this comment.
we have staging-eu?
| @@ -76,26 +110,70 @@ jobs: | |||
| services+=("\"webhook\"") | |||
| fi | |||
|
|
|||
| # Parse service secrets and generate deploy_matrix | |||
There was a problem hiding this comment.
where will we see those matrices? 👏
| outputs: | ||
| docker_image: ${{ steps.build-image.outputs.IMAGE }} | ||
| registry: ${{ steps.build-image.outputs.registry }} |
There was a problem hiding this comment.
is it common to call an image as registry?
There was a problem hiding this comment.
where are the vars defined?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the deployment workflow and Dockerfile configurations. The changes primarily focus on improving the deployment process by modifying environment settings, introducing new matrices, and updating Dockerfile bases.
Workflow Improvements:
.github/workflows/deploy.yml: Changed the default environment from 'development' to 'staging' and updated environment options. Removed question marks from descriptions..github/workflows/deploy.yml: Addeddeploy_matrixandnr_matrixto the outputs and steps for generating these matrices..github/workflows/deploy.yml: Introduced steps to parse service secrets and generatedeploy_matrix..github/workflows/deploy.yml: Modified the build step to use the newregistryoutput and updated the Docker build process..github/workflows/deploy.yml: Added new jobs for Sentry release, New Relic release, and syncing state to Novu.Dockerfile Updates:
apps/api/Dockerfile: Switched the base image fromnode:20-alpine3.19toghcr.io/novuhq/novu/base:1.0.0.apps/worker/Dockerfile: Added new lines for better readability and consistency.apps/ws/Dockerfile: Changed the base image toghcr.io/novuhq/novu/base:1.0.0and adjusted the file copy commands. [1] [2]