refactor(api-service): logger to pinologger #8128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion' of github.com:novuhq/novu into nv-5651-investigate-why-log-levels-dont-work-in-production
djabarovgeorge
changed the title
…ion' into nv-5651-api-refactor-logger-to-pinologger
Base automatically changed from
nv-5651-investigate-why-log-levels-dont-work-in-production
to
next
April 16, 2025 08:10
LetItRock
approved these changes
Apr 16, 2025
| import { createNestLoggingModuleOptions, PinoLogger } from '@novu/application-generic'; | ||
| import packageJson from '../../../../package.json'; | ||
|
|
||
| export const getLogger = (context: string) => { |
There was a problem hiding this comment.
shouldn't this come from the application generic so we can reuse in the worker if needed?
There was a problem hiding this comment.
will definitely move it once we do the same to the apps, for now i kept it close.
apps/api/src/app/workflows-v2/usecases/get-workflow/get-workflow.usecase.ts
Outdated
Show resolved
Hide resolved
|
|
||
| if (process.env.LOGGING_LEVEL || process.env.LOG_LEVEL) { | ||
| logLevel = process.env.LOGGING_LEVEL || process.env.LOG_LEVEL; |
There was a problem hiding this comment.
shouldn't this be reversed? like
Suggested change
| logLevel = process.env.LOGGING_LEVEL || process.env.LOG_LEVEL; | |
| logLevel = process.env.LOG_LEVEL || process.env.LOGGING_LEVEL; |
There was a problem hiding this comment.
its not about priority here, so any value should be fine, it's meant to be only kept for some time to support backward the old environment variable.
✅ Deploy Preview for dashboard-v2-novu-staging canceled.
|
…messages e2e test
…idgeRequest use case
…m:novuhq/novu into nv-5651-api-refactor-logger-to-pinologger
…ved logging verification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer