-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(api-service): enhance platform notification usage with caching and detailed diagnostics #9859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…add total count calculation
|
Hey there and thank you for opening this pull request! 👋 We require pull request titles to follow specific formatting rules and it looks like your proposed title needs to be adjusted. Your PR title is: Requirements:
Expected format: Details: PR title must end with 'fixes TICKET-ID' (e.g., 'fixes NOV-123') or include ticket ID in branch name |
✅ Deploy Preview for dashboard-v2-novu-staging canceled.
|
WalkthroughSubmodule reference updated from 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@libs/application-generic/src/services/analytic-logs/workflow-run/workflow-run.repository.ts`:
- Around line 830-846: The current logging block computes totalCount and passes
sampleResults to this.logger.debug even for platform-wide queries, risking
cross-tenant leakage; modify the logging so that when organizationId is
undefined you either omit sampleResults or redact tenant identifiers before
including them (keep totalCount and resultCount intact), e.g., conditionally set
sampleResults = organizationId ? result.data.slice(0,5) : [] or map result.data
to remove/blur tenant fields; update the invocation around totalCount,
this.logger.debug, sampleResults, and any use of result.data to ensure only
org-scoped samples (or redacted entries) are logged.
libs/application-generic/src/services/analytic-logs/workflow-run/workflow-run.repository.ts
Show resolved
Hide resolved
commit: |
LaunchDarkly flag references🔍 1 flag added or modified
|
What changed? Why was the change needed?
EE-PR
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer